Character Height Slider #45
Conversation
* Basic Implementation * Working implementation.
DEATHB4DEFEAT
added
Size: 3-Medium
github-actions
bot
added
Status: Needs Review
There was a problem hiding this comment.
Bunch of thoughts on this.
Does this work properly yet? On Nyano, any adjustment to zoom ruined species set zoom, and I didn't like that at all. The shuttle console, for instance, would reset your vision to 1.
I think the mob prototypes for species should probably still be scaled by default just for spawning purposes at times when the adjustment won't take place. At the worst it seems like it probably doesn't need to be gotten rid of.
I don't love small species like Felinids being able to be as tall as a human by default. Perhaps combining this with unusually tall and unusually short traits would be ideal?
Content.Shared/SimpleStation14/HeightAdjust/HeightAdjustSystem.cs
Outdated
Show resolved
Hide resolved
|
I'm still of the opinion that height should be vertical, and not horizontal :P |
I think it still does that, I'll fix that.
I think they get scaled to the default of their speciesProtoype when spawned, need to double check. |
what was I thinking??
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
This is pretty incredible. I went into this wanting to ask some questions, expecting it to maybe have some of the problems that CD's version was. I was pleasantly surprised that everything I had thought to ask about was already addressed. Even game balance by modifying fixtures, mass, and viewpoint.
Description copied from my Wizard's Den PR Resolves Simple-Station/Einstein-Engines#32 # TODO - [x] CVars - [x] Server side loadout point validation - Make tabContainer less bad - [x] Move head clothes to loadouts from lockers - [x] Move job starting equipment to loadouts - [x] Loadout item preview - [x] Fix loadouts duplicating on server restart - [x] Make sure everything is localized -- Components and Tags are an odd thing to display to the player in the whitelist and are very unrealistic to make localizations for, so.. not doing that, what do I do? - [x] Fix all items going into the bag no matter their size - [x] Add min/cur/max points to the bar - [x] Use buttons instead of checkboxes - [x] "Show Unusable" button to hide things your character currently doesn't match the whitelists for - [x] Time whitelist option - [x] Species whitelist option - [x] Trait whitelist option instead of EntityWhitelist for the sake of localization - [ ] More loadouts (filler things while waiting for review) - [ ] - Golden or themed items for Command roles with an undecided amount of playtime on their respective jobs - [x] - Goliath cloak for playing a lot of Salvage - [x] - Senior items for playing a lot of its respective role - [ ] - Varying materials of pocket watches for people with varying overall playtime - [x] Fix loadout selectors not updating to match current preferences <details><summary><h1>Media (Click Me!)</h1></summary> <p> I need to rerecord these https://github.com/space-wizards/space-station-14/assets/77995199/59713874-b043-4813-848e-56b2951b6935 https://github.com/space-wizards/space-station-14/assets/77995199/40180aee-bfe3-4f30-9df8-0f628e7e4514 </p> </details> # Changelog :cl: - add: Added a new character customization tab for selecting items to start your shift with, loadouts! - remove: Removed some default job equipment in favor of loadouts - remove: Removed several clothing items from Command lockers in favor of loadouts --------- Co-authored-by: VMSolidus <[email protected]>
Description
Based partially off of the height "slider" PR from Cosmatic Drift
Adds a slider to the character customization UI that changes eye zoom, fixture size, and sprite size (similarly to the old height adjust traits) with a per-species min/max/default set of values.
Media
Displayed sizes may or may not be accurate to the ones available in-game
2024-01-27_21-46-26.mp4
2024-01-27_21-31-14.mp4
2024-01-27_21-41-27.mp4
Changelog
🆑